-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: enable sret for dynamic arrays #901
Conversation
Oh yes, I'm already loving this |
@@ -221,7 +221,7 @@ struct X86_64TargetABI : TargetABI { | |||
|
|||
llvm::CallingConv::ID callingConv(LINK l); | |||
|
|||
bool returnInArg(TypeFunction* tf); | |||
bool returnInArg(Type* tf, LINK linkage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tf => rt
@JohanEngelen You should make the |
@JohanEngelen Could you please write me an email? I am not sure if I have a valid mail address from you. |
@redstar I've set my email to public on github. |
@redstar :'( I thought C++11 is available generally (it apparently is on win64). But it isn't... I guess it is not possible to require C++11? (LLVM 3.6+ does require it I thought?) |
I do think we should look into transitioning to LLVM 3.5+ and C++11 soon. However, we can't do this without having a proper plan of attack first, lest we want to upset package maintainers and users. |
Yeah, ok. I will rewrite things to work with C-arrays, like the LLVM functions do. (maybe faster too, preventing dyn allocs...) |
…o use sret or not.
…perfunction. Enable sret-arrays for Win64
9e8dc0e
to
0846c27
Compare
OK, I got things to work with sret arrays now on Win64. Note that dyn arrays are not passed byref still. For that to work, more work is needed in defining the runtime functions, and also in the calling code. (the helperfunctions should be extended in functionality, and the calling code should be made less ABI aware). |
…e must be changed in a number of places for that)
Changes Unknown when pulling 555b8ba on JohanEngelen:abi-sret-win64 into * on ldc-developers:master*. |
trying to pick this up again. |
closing PR, going to start from scratch. |
Great news!
I'll take care of that, so that you're free to ask |
Work In Progress!
The goal is to enable dynarray sret for Win64 and other platforms that wish it.
Making a PR to have Travis check the code on other platforms.
All comments are welcome.